Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional annotations to the extra configmap and secrets #30303

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

sudeepgupta90
Copy link
Contributor

@sudeepgupta90 sudeepgupta90 commented Mar 26, 2023

Add provision to have additional annotations to the extra configmap and secrets


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, if and with are similar, but I prefer to change it to follow the same pattern used in recent PRs on the helm chart.

@sudeepgupta90
Copy link
Contributor Author

sudeepgupta90 commented Mar 27, 2023

The failing test does not seem related to the changes I made. Any suggestions/help appreciated 🙏

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potiuk potiuk merged commit 82c5a5f into apache:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants