Fix DAG.access_control can't sync when clean access_control #30340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huymq1710
requested review from
jhtimmins,
kaxil,
XD-DENG and
ashb
as code owners
huymq1710
commented
Mar 28, 2023
| return True | ||
| return False | ||
|
|
||
| if dag.access_control or needs_perms(root_dag_id): |
There was a problem hiding this comment.
Remove this if block completely so we sync perms in both cases. This is effectively reverting #15464.
huymq1710
commented
Mar 28, 2023
Comment on lines
+659
to
+676
| else: | ||
| resource = self.get_resource(dag_resource_name) | ||
| if resource: | ||
| _revoke_all_stale_permissions(resource) |
There was a problem hiding this comment.
If a DAG’s access_control is empty, it check whether there’s existing permission configurations and reset those
|
Do you have any plan to merge it? I need this one for my project :( |
|
This PR is ready for review |
potiuk
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
LGTM. But I know very little about that part of the codebase. @ephraimbuddy @kaxil @uranusjr - I think you've been doing some "real fixes" around that - maybe second opinon there?
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Reset permission if `access_control` is empty * Check `resource` before call `_revoke_all_stale_permissions` * Fix static checks (cherry picked from commit 2c0c8b8)
62 tasks
This was referenced Jul 25, 2023
2 tasks
|
Update: #33632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #25149
access_controlis empty, permission-sync is skipped entirely. I think it should check whether there’s existing permission configurations and reset those if needed instead.