Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save scheduler execution time by caching dags #30704

Merged
merged 8 commits into from
May 18, 2023
Merged

Save scheduler execution time by caching dags #30704

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bcf63ed
Added dag caching during scheduling
AutomationDev85 Apr 18, 2023
9e263fa
Correct comments
AutomationDev85 Apr 18, 2023
3efb5d3
Added cache function to helpers
AutomationDev85 Apr 19, 2023
e993053
use of lambda for caching
AutomationDev85 Apr 20, 2023
2783c9e
Added dag caching with lru_cache function
AutomationDev85 Apr 27, 2023
53c91cf
Merge remote-tracking branch 'origin/main' into feature/optimize-sche…
jscheffl May 14, 2023
0d90c97
Apply review feedback, migrate lambda function to functool.partial, a…
jscheffl May 14, 2023
19e9537
Merge remote-tracking branch 'origin/main' into feature/optimize-sche…
jscheffl May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions airflow/jobs/scheduler_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,8 +1083,13 @@ def _do_scheduling(self, session: Session) -> int:
callback_tuples = self._schedule_all_dag_runs(guard, dag_runs, session)

# Send the callbacks after we commit to ensure the context is up to date when it gets run
# cache saves time during scheduling of many dag_runs for same dag
cached_dags: dict = {}
for dag_run, callback_to_run in callback_tuples:
dag = self.dagbag.get_dag(dag_run.dag_id, session=session)
if dag_run.dag_id not in cached_dags.keys():
cached_dags[dag_run.dag_id] = self.dagbag.get_dag(dag_run.dag_id, session=session)

dag = cached_dags[dag_run.dag_id]
AutomationDev85 marked this conversation as resolved.
Show resolved Hide resolved
if not dag:
self.log.error("DAG '%s' not found in serialized_dag table", dag_run.dag_id)
continue
Expand Down Expand Up @@ -1347,9 +1352,14 @@ def _update_state(dag: DAG, dag_run: DagRun):
schedule_delay,
tags={"dag_id": dag.dag_id},
)
# cache saves time during scheduling of many dag_runs for same dag
cached_dags: dict = {}

for dag_run in dag_runs:
dag = dag_run.dag = self.dagbag.get_dag(dag_run.dag_id, session=session)
if dag_run.dag_id not in cached_dags.keys():
cached_dags[dag_run.dag_id] = self.dagbag.get_dag(dag_run.dag_id, session=session)

dag = dag_run.dag = cached_dags[dag_run.dag_id]
if not dag:
self.log.error("DAG '%s' not found in serialized_dag table", dag_run.dag_id)
continue
Expand Down