Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with displaying graph #30765

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix problem with displaying graph #30765

merged 1 commit into from
May 3, 2023

Conversation

meujin
Copy link
Contributor

@meujin meujin commented Apr 20, 2023

If run_id is presented in the graph URL for example: http://localhost:8080/dags/simple_dag/graph?run_id=scheduled__2023-03-14T12%3A47%3A00%2B00%3A00&execution_date=2023-03-14+12%3A47%3A00%2B00%3A00
query_date will be equal to base_date which set as:
(timezone.utcnow() + timedelta(seconds=1)).replace(microsecond=0)
And drs will contain only recent num_runs results which may not include dag_run with desirable execution_date, instead of this you will have the latest one.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

If run_id is presented in the graph URL for example:
http://localhost:8080/dags/simple_dag/graph?run_id=scheduled__2023-03-14T12%3A47%3A00%2B00%3A00&execution_date=2023-03-14+12%3A47%3A00%2B00%3A00
query_date will be equal to base_date which set as (timezone.utcnow() + timedelta(seconds=1)).replace(microsecond=0)
And drs will contain only recent num_runs results which may not include dag_run with desirable execution_date, instead of this you will have the latest one.
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 20, 2023
@bbovenzi
Copy link
Contributor

I think this makes sense to me. How about you @uranusjr ?

@meujin
Copy link
Contributor Author

meujin commented May 3, 2023

@bbovenzi any progress with that?

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should document the logic in the docstring (what fields are parsed when and how), that could make the logic easier to infer.

@bbovenzi bbovenzi added this to the Airflow 2.6.1 milestone May 3, 2023
@bbovenzi bbovenzi merged commit eb7b98d into apache:main May 3, 2023
41 checks passed
@bbovenzi
Copy link
Contributor

bbovenzi commented May 3, 2023

This view is essentially deprecated, and will probably be removed in 2.7.

@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label May 8, 2023
ephraimbuddy pushed a commit that referenced this pull request May 8, 2023
If run_id is presented in the graph URL for example:
http://localhost:8080/dags/simple_dag/graph?run_id=scheduled__2023-03-14T12%3A47%3A00%2B00%3A00&execution_date=2023-03-14+12%3A47%3A00%2B00%3A00
query_date will be equal to base_date which set as (timezone.utcnow() + timedelta(seconds=1)).replace(microsecond=0)
And drs will contain only recent num_runs results which may not include dag_run with desirable execution_date, instead of this you will have the latest one.

(cherry picked from commit eb7b98d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants