Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order_by request in list DAG rest api #30926

Merged
merged 3 commits into from
Apr 29, 2023

Conversation

pankajastro
Copy link
Member

currently, list DAG API i.e. GET /dags does not use
order_by param i.e. ignore it and because of that API returns
unexpected results. Also, it does not throw errors when the user
passes an incorrect order_by param. In this PR, fix the broken support
for reversing ordering.

closes: #30900


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Apr 27, 2023
@pankajastro pankajastro marked this pull request as ready for review April 27, 2023 23:12
@pankajastro pankajastro changed the title Fix order_by in list DAG rest api Fix order_by request in list DAG rest api Apr 28, 2023
@pankajastro pankajastro changed the title Fix order_by request in list DAG rest api Fix order_by request in list DAG rest api Apr 28, 2023
@potiuk potiuk merged commit 1d4b141 into apache:main Apr 29, 2023
42 checks passed
@potiuk potiuk added this to the Airflow 2.6.1 milestone Apr 29, 2023
@pankajastro pankajastro deleted the fix_list_dag_ordering branch May 1, 2023 16:09
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label May 8, 2023
ephraimbuddy pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API, order_by parameter in dags list is not taken into account
3 participants