Fix output for airflow providers get command
#30978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
changed the title
airflow providers get command outputairflow providers get command
If I use the `airflow provider get <provider-name> -o json/yaml` CLI command it does not respect `-o` option. It works perfectly fine when I pass the `--full` option also in the above command. The issue is currently if the `--full` option is not provided we use standard statement print to print results and not the custom AirflowConsole. In this PR I'm replacing print with `AirflowConsole().print_as`
pankajastro
force-pushed
the
fix_provider_get_cmd
branch
from
2c602b5
to
e13510d
Compare
potiuk
approved these changes
May 1, 2023
|
NIce! |
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2023
If I use the `airflow provider get <provider-name> -o json/yaml` CLI command it does not respect `-o` option. It works perfectly fine when I pass the `--full` option also in the above command. The issue is currently if the `--full` option is not provided we use standard statement print to print results and not the custom AirflowConsole. In this PR I'm replacing print with `AirflowConsole().print_as` (cherry picked from commit 23b5b31)
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I use the
airflow provider get <provider-name> -o json/yamlCLI command it does not respect-ooption. It works perfectly fine when I pass the--fulloption also in the above command. The issue is currently if the--fulloption is not provided we use standard statement print to print results and not the custom AirflowConsole. In this PR I'm replacing print withAirflowConsole().print_asBefore
After
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.