Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter #31040

Closed

Conversation

thomas-vt
Copy link

@thomas-vt thomas-vt commented May 3, 2023

This PR is for integrating kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack

Reference

related: #28779

@sudeepgupta90 @potiuk @jedcunningham @dstandish @ephraimbuddy please review


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label May 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 3, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@sudeepgupta90
Copy link
Contributor

You would also need to have appropriate tests before this can be merged @thomas-vt

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 19, 2023
@github-actions github-actions bot closed this Jun 24, 2023
@yurivenancio30
Copy link

Any updates?!?

@ArieLevs
Copy link

Hi @sudeepgupta90
I also have use case where id like to have the serviceMonitor integrated into the airflow chart (currently i create my own serviceMonitor, airflow chart is a dependency).

I don't mind pushing this forward, could you provide a quick guide on the chart test framework, where the tests are or how are they executed (i will have to open a new PR)

@shalberd
Copy link

shalberd commented Jun 6, 2024

yeah, having that option, especially when statsd is enabled anyways ... is really so useful, no reason not to include ServiceMonitor

@lucasfcnunes
Copy link
Contributor

Hi @sudeepgupta90 I also have use case where id like to have the serviceMonitor integrated into the airflow chart (currently i create my own serviceMonitor, airflow chart is a dependency).

I don't mind pushing this forward, could you provide a quick guide on the chart test framework, where the tests are or how are they executed (i will have to open a new PR)

@ArieLevs we did the same (https://github.com/yurivenancio30/airflow-chart/blob/main/charts/postgresql/templates/read/servicemonitor.yaml)

FYI @yurivenancio30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants