-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter #31040
Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter #31040
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Co-authored-by: Sudeep Gupta <sudeepgupta90@users.noreply.github.com>
You would also need to have appropriate tests before this can be merged @thomas-vt |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Any updates?!? |
Hi @sudeepgupta90 I don't mind pushing this forward, could you provide a quick guide on the chart test framework, where the tests are or how are they executed (i will have to open a new PR) |
yeah, having that option, especially when statsd is enabled anyways ... is really so useful, no reason not to include ServiceMonitor |
@ArieLevs we did the same (https://github.com/yurivenancio30/airflow-chart/blob/main/charts/postgresql/templates/read/servicemonitor.yaml) FYI @yurivenancio30 |
This PR is for integrating kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack
Reference
related: #28779
@sudeepgupta90 @potiuk @jedcunningham @dstandish @ephraimbuddy please review
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.