Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable mode to GCSUploadSessionCompleteSensor #31081

Merged
merged 7 commits into from
May 25, 2023

Conversation

phanikumv
Copy link
Contributor

This PR donates the GCSUploadSessionCompleteSensorAsync from astronomer-providers to Airflow


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add doc changes and example DAGs as well as part of this PR

@phanikumv phanikumv force-pushed the gcs_upload branch 2 times, most recently from 8681b0a to ad3f3f2 Compare May 16, 2023 03:30
Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, minor suggestions inline if you'd like to consider.

airflow/providers/google/cloud/sensors/gcs.py Outdated Show resolved Hide resolved
airflow/providers/google/cloud/triggers/gcs.py Outdated Show resolved Hide resolved
@ephraimbuddy ephraimbuddy merged commit 5ae9728 into apache:main May 25, 2023
42 checks passed
@ephraimbuddy ephraimbuddy deleted the gcs_upload branch May 25, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants