Fix url_for_asset fallback and 404 on DAG Audit Log
#31233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a 404 on the DAG Audit Log for bootstrap toggle css, which as far as I can tell, we aren't even trying to use. So we will no longer try and add it to the page. This highlighted the fact that if we don't have an asset in the manifest, `url_for_asset` would just leave off the filename completely. This resulted in the href being just `/static/`, with no filename as a breadcrumb in the eventual 404. Now we will just use the filename as-is so the 404 is more meaningful.
jedcunningham
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
bbovenzi
approved these changes
May 12, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
There was a 404 on the DAG Audit Log for bootstrap toggle css, which as far as I can tell, we aren't even trying to use. So we will no longer try and add it to the page. This highlighted the fact that if we don't have an asset in the manifest, `url_for_asset` would just leave off the filename completely. This resulted in the href being just `/static/`, with no filename as a breadcrumb in the eventual 404. Now we will just use the filename as-is so the 404 is more meaningful. (cherry picked from commit 2b4ad8a)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
There was a 404 on the DAG Audit Log for bootstrap toggle css, which as far as I can tell, we aren't even trying to use. So we will no longer try and add it to the page. This highlighted the fact that if we don't have an asset in the manifest, `url_for_asset` would just leave off the filename completely. This resulted in the href being just `/static/`, with no filename as a breadcrumb in the eventual 404. Now we will just use the filename as-is so the 404 is more meaningful. (cherry picked from commit 2b4ad8a)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a 404 on the DAG Audit Log for bootstrap toggle css, which as far as I can tell, we aren't even trying to use. So we will no longer try and add it to the page.
This highlighted the fact that if we don't have an asset in the manifest,
url_for_assetwould just leave off the filename completely. This resulted in the href being just/static/, with no filename as a breadcrumb in the eventual 404. Now we will just use the filename as-is so the 404 is more meaningful.