Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable mode to PubsubPullSensor #31284

Merged
merged 1 commit into from Jun 14, 2023
Merged

Add deferrable mode to PubsubPullSensor #31284

merged 1 commit into from Jun 14, 2023

Conversation

bkossakowska
Copy link
Contributor

Add deferrable mode to PubsubPullSensor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the PubSubAsyncHook please

@bkossakowska bkossakowska marked this pull request as draft May 17, 2023 06:14
@bkossakowska bkossakowska marked this pull request as ready for review May 25, 2023 08:39
@bkossakowska bkossakowska force-pushed the pubsub branch 2 times, most recently from e65ea44 to 1866784 Compare June 1, 2023 08:37
@bkossakowska bkossakowska force-pushed the pubsub branch 2 times, most recently from dc9956a to ec0c8b4 Compare June 9, 2023 14:35
@bkossakowska
Copy link
Contributor Author

@phanikumv
tests are added

@bkossakowska
Copy link
Contributor Author

Hi @phanikumv, @potiuk
thanks for your comments, changes have been added. Is there anything else I can improve?

Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit a81ac70 into apache:main Jun 14, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants