-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifier for Smtp #31359
Merged
Merged
Add notifier for Smtp #31359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static checks failing are unrelated to this PR, please check the slack thread - https://apache-airflow.slack.com/archives/CCPRP7943/p1685011999082929 |
jedcunningham
approved these changes
May 30, 2023
dstandish
reviewed
May 31, 2023
ephraimbuddy
reviewed
Jun 3, 2023
|
||
from typing import Any, Iterable | ||
|
||
from airflow.compat.functools import cached_property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can import this from python directly now since 3.7 has been removed
ephraimbuddy
approved these changes
Jun 7, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 7, 2023
The apache#31359 and apache#31742 were merged independently and the first one did not have the fixes enabled by the second. This PR fixes it.
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send email via SMTP notifier.
Example usage -