Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Save scheduler execution time by caching dags (#30704)" #31413

Merged
merged 1 commit into from
May 19, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented May 19, 2023

This reverts commit e065f6a.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label May 19, 2023
@potiuk potiuk requested a review from eladkal May 19, 2023 11:40
@potiuk
Copy link
Member Author

potiuk commented May 19, 2023

We need to revert it for now @AutomationDev85 as the original change breaks MSSQL - you will have to recreate the PR (and we will add `full-tests-needed' flag to test it with mssql

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe time to start thinking about dropping mssql support as backend?
I don't think it brings the value we thought it would...

@potiuk potiuk merged commit e6f2117 into apache:main May 19, 2023
34 of 35 checks passed
@potiuk potiuk deleted the revert-index-add branch May 19, 2023 11:48
@potiuk
Copy link
Member Author

potiuk commented May 19, 2023

Maybe time to start thinking about dropping mssql support as backend? I don't think it brings the value we thought it would...

I would very very much like that

@potiuk
Copy link
Member Author

potiuk commented May 19, 2023

A actualy want to wait for result of the survey (which BTW I thikn it's a good idea to run so that we know the results before the summit @TohnJhomas

@potiuk
Copy link
Member Author

potiuk commented May 19, 2023

Not @merobi-hub but @TohnJhomas :)

@merobi-hub
Copy link
Contributor

merobi-hub commented May 19, 2023 via email

@potiuk
Copy link
Member Author

potiuk commented May 19, 2023

Ahh :) . So that was a subconscious guess :)

potiuk added a commit to potiuk/airflow that referenced this pull request May 19, 2023
potiuk added a commit that referenced this pull request May 19, 2023
* Revert "Revert "Save scheduler execution time by caching dags (#30704)" (#31413)"

This reverts commit e6f2117.

* Revert "Save scheduler execution time by adding new Index idea for dag_run (#30827)"

This reverts commit c63b777.
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 6, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.0 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants