Fix typing in external task triggers #31490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The session kwargs should have a NEW_SESSION default when decorated with provide_session. Not sure why Mypy did not catch this earlier, but it is correctly complaining about it now.
ephraimbuddy
approved these changes
May 24, 2023
potiuk
approved these changes
May 24, 2023
|
Looks like it may still be complaining about it? |
eladkal
added
the
type:misc/internal
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit b353621)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit b353621)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session kwargs should have a NEW_SESSION default when decorated with provide_session. Not sure why Mypy did not catch this earlier, but it is correctly complaining about it now.