Testing connection - clearing old alert box when testing connection #31606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
pankajkoti
reviewed
May 30, 2023
There was a problem hiding this comment.
Nice, it confuses me too, I often go to the browser console to check the response of the newer requests with modified payloads 😄.
Not much expertise with JS here, but if hiding the alert box is the right solution, I like the idea and the fix! Thank you for this! 👏🏽
|
@pankajkoti This was the easiest solution. Ideally, there should be a loader/spinner next to the |
bbovenzi
approved these changes
May 30, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit efe8473)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit efe8473)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the connection for the second time the alert box with the old value is confusing, it can mean two things
Better to clear it before making a testing call.