Refactor Eks Create Cluster Operator code #31960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
phanikumv
reviewed
Jun 16, 2023
o-nikolas
reviewed
Jun 16, 2023
o-nikolas
reviewed
Jun 16, 2023
uranusjr
reviewed
Jun 19, 2023
uranusjr
reviewed
Jun 19, 2023
uranusjr
reviewed
Jun 19, 2023
| self.eks_hook = EksHook(aws_conn_id=self.aws_conn_id, region_name=self.region) | ||
| super().__init__(**kwargs) | ||
|
|
||
| def create_compute(self): |
There was a problem hiding this comment.
Suggested change
| def create_compute(self): | |
| def create_compute(self) -> None: |
And now Mypy would start to prompt you adding variable definitions on the class (which is good)
There was a problem hiding this comment.
I made this change, and it ended up having a bigger impact than I anticipated. I had to add a bunch of parameters used in the 3 child classes. I think I've got everything ready. I need to do some testing with how templating works here. Right now, _BaseEksCreateOperator doesn't have any templated fields, but because the child classes allow templating for some parameters, I think I have to do the same for _BaseEksCreateOperator.
@uranusjr what do you think?
vincbeck
approved these changes
Jun 19, 2023
uranusjr
approved these changes
Jun 21, 2023
|
Looks like there’s a coverage error. Maybe caused by the base class name change? |
Add waiter params to EksCreateClusterOperator and EksCreateNodegroupOperator Update EksCreateFargateProfileTrigger and EksDeleteFargateProfileTrigger to use more consistent waiter names Update unit tests for triggers and operators
…is meant to be a parent class to some of the Eks operators
Minor PR comment fixes
syedahsn
force-pushed
the
syedahsn/eks-cluster-operator-refactor
branch
from
e1c2a92
to
745c57a
Compare
o-nikolas
approved these changes
Jun 23, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
* Refactor EksCreateClusterOperator to reuse code being used in multiple places * Update create_compute method to pass tests Add waiter params to EksCreateClusterOperator and EksCreateNodegroupOperator Update EksCreateFargateProfileTrigger and EksDeleteFargateProfileTrigger to use more consistent waiter names Update unit tests for triggers and operators
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EksCreateClusterOperatoris capable of creating a Fargate Profile or Nodegroup that is associated with the newly created cluster. The code for creating the Fargate Profile and Nodegroup is the same as the code inEksCreateFargateProfileOperatorandEksCreateNodegroupOperatorrespectively.This PR refactors the code to reuse some of the code to decrease code duplication. This step also simplifies adding deferrable mode to these operators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.