Fix an issue that crashes Airflow Webserver when passed invalid private key path to Snowflake #32016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
uranusjr
reviewed
Jun 20, 2023
|
Needs conflict resolving. |
phanikumv
reviewed
Jun 20, 2023
| ) | ||
| if private_key_file_path.stat().st_size > 4096: | ||
| raise ValueError( | ||
| "File size of private_key_file is too big." |
There was a problem hiding this comment.
Suggested change
| "File size of private_key_file is too big." | |
| "The private_key_file size is too big. Please keep it less than 4 KB" |
There was a problem hiding this comment.
Let's also add a note in the docs about the size limitation.
There was a problem hiding this comment.
What documentation do you suggest putting it to? The limitations is applied to the connection settings. I coulad add a note to the operator docs.
|
conflicts :( |
xrmr
suggested changes
Jul 5, 2023
Co-authored-by: xrmr <17521278+xrmr@users.noreply.github.com>
|
Needs conflict resolving @bjankie1 |
potiuk
approved these changes
Jul 7, 2023
potiuk
approved these changes
Jul 8, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing path on an excessively large file or path to a system device crashes Webserver. This fix validates the path against such situations.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.