add dag_run_ids and task_ids filter for the batch task instance API endpoint #32705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karakanb
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
karakanb
force-pushed
the
introduce-dagrun-and-task-id-filters-batch-api
branch
2 times, most recently
from
15d8f64
to
59d0c1e
Compare
|
Can you add “New in version” markers to the parameters in the OpenAPI spec please? There are various examples if you search in the file. |
karakanb
force-pushed
the
introduce-dagrun-and-task-id-filters-batch-api
branch
4 times, most recently
from
64fb437
to
384e360
Compare
|
@uranusjr done, assumed it'd go in 2.6.4, please take a look. |
karakanb
force-pushed
the
introduce-dagrun-and-task-id-filters-batch-api
branch
from
384e360
to
1074524
Compare
|
not sure if maintainers can do that right away but please feel free to modify any files here before you merge as you see fit, e.g. fixing the version. if you let me know what'd be the right version number I can also do that. |
|
I think will hold-off with those merges for a short while due to cutting out 2.7.0 release, but I think @pierrejeambrun looked at the open-api changes recently :) |
pierrejeambrun
approved these changes
Aug 5, 2023
pierrejeambrun
force-pushed
the
introduce-dagrun-and-task-id-filters-batch-api
branch
from
56f1e74
to
78c5de0
Compare
uranusjr
approved these changes
Aug 7, 2023
potiuk
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new filters for the batch task instance endpoint:
dag_run_ids: a set of DAG Run IDs to filter the instances that were in those runstask_ids: a set of task IDs that the instances were forLet me know if you have any feedback.