[AIRFLOW-2266] Resolve gcp_api installation for Python 3 #3273
Conversation
kaxil
force-pushed
the
patch-3
branch
3 times, most recently
from
3ad4289
to
c24ec97
Compare
|
@fenglu-g Can you please take a look at this? I have removed the dataflow dependency as we discussed in the other thread. (#2388 (comment)) |
|
cc @Fokko PTAL |
|
@kaxil please have a look at why the builds fail |
|
LGTM on the google-data-flow library removal. |
|
@bolkedebruin The errors are related to Flask (new version breaks Airflow Webserver - [AIRFLOW-2384]) and should be resolved once #3272 is merged to master. |
|
Please rebase onto master. Thanks for picking this up. This will make @NielsZeilemaker happy :-) Python 3 support is addressed in this ticket: https://issues.apache.org/jira/browse/BEAM-1251 |
This is caused due to the fact that the latest release (2.4) for apache-beam[gcp] is not available for Python 3.x. Also as we are using Google's discovery based API for all google cloud related commands we don't require to import google-cloud-dataflow package
|
Done. Actually, I gave a tutorial on "Apache Airflow in the cloud" @ PyData London where some users who used Python3 had trouble installing Airflow with So, I was looking into it and found this :) |
Codecov Report
@@ Coverage Diff @@
## master #3273 +/- ##
=======================================
Coverage 75.78% 75.78%
=======================================
Files 197 197
Lines 14699 14699
=======================================
Hits 11139 11139
Misses 3560 3560Continue to review full report at Codecov.
|
This is caused due to the fact that the latest release (2.4) for apache-beam[gcp] is not available for Python 3.x. Also as we are using Google's discovery based API for all google cloud related commands we don't require to import google-cloud-dataflow package Closes #3273 from kaxil/patch-3 (cherry picked from commit e9b74b6) Signed-off-by: Fokko Driesprong <fokkodriesprong@godatadriven.com>
This is caused due to the fact that the latest release (2.4) for apache-beam[gcp] is not available for Python 3.x. Also as we are using Google's discovery based API for all google cloud related commands we don't require to import google-cloud-dataflow package Closes apache#3273 from kaxil/patch-3
| @@ -206,8 +205,7 @@ def write_version(filename=os.path.join(*['airflow', | |||
| # Snakebite & Google Cloud Dataflow are not Python 3 compatible :'( | |||
There was a problem hiding this comment.
You should also update a comment.
Make sure you have checked all steps below.
JIRA
Description
This is caused due to the fact that the latest release (2.4) for apache-beam[gcp] is not available for Python 3.x. Also as we are using Google's discovery-based API for all google cloud related commands we don't require to import google-cloud-dataflow package
Tests
N/A
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff