Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize the conn_id to disallow potential script execution #32867

Merged
merged 33 commits into from Jan 16, 2024
Merged

Sanitize the conn_id to disallow potential script execution #32867

merged 33 commits into from Jan 16, 2024
+128 −5

Commits on Jul 26, 2023

  1. sanitize the conn_id to disallow potential script execution

    @andylamp
    andylamp committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8b52ca7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @andylamp
    andylamp committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8da482d View commit details
    Browse the repository at this point in the history

  3. update docs and naming of the regex to better indicate its purpose

    @andylamp
    andylamp committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6a4a01d View commit details
    Browse the repository at this point in the history

  4. use re2 instead of re, as per static checks

    @andylamp
    andylamp committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c0d2143 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Update airflow/models/connection.py 

    Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @andylamp @uranusjr
    andylamp and uranusjr committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2912fec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @andylamp
    andylamp committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    a78c149 View commit details
    Browse the repository at this point in the history

  3. refactor to return the first matched group, which is out desired outcome

    @andylamp
    andylamp committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    735b34b View commit details
    Browse the repository at this point in the history

  4. tweak the comments

    @andylamp
    andylamp committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    44a7211 View commit details
    Browse the repository at this point in the history

  5. add a test suite for the regex sanitization

    @andylamp
    andylamp committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    54e7cd4 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. fix the docs linter, change to en-US instead of en-GB

    @andylamp
    andylamp committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    bfdcf86 View commit details
    Browse the repository at this point in the history

  2. remove docstrings from test

    @andylamp
    andylamp committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    546afff View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Merge branch 'main' into main

    @andylamp
    andylamp committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    96d72c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. update to fix integration tests

    @andylamp
    andylamp committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    a524a5e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @andylamp
    andylamp committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    7882372 View commit details
    Browse the repository at this point in the history

  3. update to remove logging that messes up tests

    @andylamp
    andylamp committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    fa14397 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main'

    @andylamp
    andylamp committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    304836b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into main

    @andylamp
    andylamp committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    9cf14cb View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Merge branch 'main' into main

    @andylamp
    andylamp committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f9cd0b6 View commit details
    Browse the repository at this point in the history

  2. Update airflow/models/connection.py 

    Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @andylamp @uranusjr
    andylamp and uranusjr committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    997e648 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. remove commented code

    @andylamp
    andylamp committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b1ee2e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. push regex update to handle aws ARN format

    @andylamp
    andylamp committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    c04caef View commit details
    Browse the repository at this point in the history

  2. make ruff happy

    @andylamp
    andylamp committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    088f0de View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main

    @andylamp
    andylamp committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    5491fe6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main'

    @andylamp
    andylamp committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    5408199 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. add validator to form

    @andylamp
    andylamp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    6aa9612 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' 

    # Conflicts:
#	airflow/www/forms.py
#	airflow/www/validators.py
    @andylamp
    andylamp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    0dc4134 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. feat: add sanitization, proper messaging to FAB, fix errors/tests

    @andylamp
    andylamp committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    f8aa6d2 View commit details
    Browse the repository at this point in the history

  2. bugfix: typo in function docs

    @andylamp
    andylamp committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    68d9bdc View commit details
    Browse the repository at this point in the history

  3. bugfix: typo in function docs, add example for the regex

    @andylamp
    andylamp committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    5ad35ca View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into main

    @andylamp
    andylamp committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    156f3fc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into main

    @andylamp
    andylamp committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e1c126c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into main

    @andylamp
    andylamp committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    3feef94 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into main

    @andylamp
    andylamp committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    90b3220 View commit details
    Browse the repository at this point in the history