Extend task context logging support for remote logging using AWS S3 #32950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:logging
area:providers
provider:amazon-aws
pankajkoti
changed the title
pankajkoti
changed the title
uranusjr
approved these changes
Jul 31, 2023
phanikumv
approved these changes
Jul 31, 2023
|
Backward compatibility test by putting this change on top of main branch locally: Feature testing by putting these changes on the base PR branch which adds the feature in Airflow Core: With this change for AWS S3 remote logging when tasks fail in scheduler: |
uranusjr
previously approved these changes
Aug 1, 2023
uranusjr
dismissed
their stale review
Static checks indicate there’s an implementation error somewhere.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
With the addition of taxt context logging feature in PR apache#32646, this PR extends the feature to AWS S3 when is it set as remote logging store. Here, backward compatibility is ensured for older versions of Airflow that do not have the feature included in Airflow Core.
pankajkoti
force-pushed
the
task-context-log-s3-logging
branch
from
a0ab0eb
to
cb83eb1
Compare
|
Latest successful testing with S3 remote logging 
|
ephraimbuddy
added
the
changelog:skip
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of task context logging feature in PR #32646,
this PR extends the feature to AWS S3 when is it set as remote
logging store. Here, backward compatibility is ensured for older
versions of Airflow that do not have the feature included in
Airflow Core.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.