Configurable health check threshold for triggerer #33089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-nikolas
requested review from
dstandish,
kaxil,
ashb and
XD-DENG
as code owners
boring-cyborg
bot
added
area:Scheduler
o-nikolas
commented
Aug 3, 2023
|
|
||
|
|
||
| @pytest.mark.parametrize("check_triggerer_heartrate", [10, 60, 300]) | ||
| def test_assign_unassigned_missing_heartbeat(session, create_task_instance, check_triggerer_heartrate): |
There was a problem hiding this comment.
A new assert was added to the above test that covers the usecase this tests was trying to cover. This test was quite long and more complicated than I think required to test this particular code branch.
Recently the Triggerer was forced to a health check threshold of `trigger_heartbeat * 2.1` with a default of 5s for the heartbeat, this generates a threshold of 10.5s, the previous threshold was 30s, this leads to a very unstable situation where Triggerers are not given a reasonable amount of time to heartbeat and their triggers are taken from them. This change allows the user to configure this threshold the same way we do for the scheduler.
o-nikolas
force-pushed
the
onikolas/configurable_triggerer_heartbeat_gracetime
branch
from
c7185b7
to
3f65b7a
Compare
potiuk
approved these changes
Aug 6, 2023
|
cc: @hussein-awala @ephraimbuddy -> i think this one should go to RC1/ |
+1 |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 8, 2023
Recently the Triggerer was forced to a health check threshold of `trigger_heartbeat * 2.1` with a default of 5s for the heartbeat, this generates a threshold of 10.5s, the previous threshold was 30s, this leads to a very unstable situation where Triggerers are not given a reasonable amount of time to heartbeat and their triggers are taken from them. This change allows the user to configure this threshold the same way we do for the scheduler. (cherry picked from commit 6ec3b9a)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the Triggerer was forced to a health check threshold of
trigger_heartbeat * 2.1with a default of 5s for the heartbeat (as of #32123), this generates a threshold of 10.5s, the previous threshold was 30s, this leads to us observing a very unstable situation in many Airflow environments where Triggerers are not given a reasonable amount of time to heartbeat and their triggers are taken from them and given to another "healthy" Triggerer. This repeats back and fourth between multiple Triggerers.This change allows the user to configure this threshold the same way we do for the scheduler.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.