Adding startupProbe to airflow services charts #33107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jedcunningham @hussein-awala can you take a look at this PR when you have some time? |
potiuk
reviewed
Aug 6, 2023
|
Yes - I think it'a good idea to add startup probe (but with lower default time) @jedcunningham @dstandish WDYT |
potiuk
approved these changes
Aug 7, 2023
ephraimbuddy
added
the
changelog:skip
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 26, 2023
We don't need to create the pod template file if we aren't using KE. This was accidentally broken in apache#33107.
jedcunningham
added a commit
that referenced
this pull request
Sep 27, 2023
We don't need to create the pod template file if we aren't using KE. This was accidentally broken in #33107.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an internal feature where we perform a copy of venv from airflow services to cloud storages which can sometimes take a few minutes. Copying of a venv is a metadata heavy load: https://learn.microsoft.com/en-us/troubleshoot/azure/azure-storage/files-troubleshoot-performance?tabs=linux#cause-2-metadata-or-namespace-heavy-workload.
Introducing a startupProbe onto the airflow services would be useful for slow starting container and most of all it doesn't have side effects. startupProbe has been added for scheduler and the webserver following the same flow as their respective liveness and readiness probes. A gracious value of 10 mins has been set for startup. This is based on personal experiments where our deployments took 5 - 6 mins for startup roughly, 10 mins allows some head room. Although, these properties are configurable and would be beneficial for users to use them.
closes: #33099
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.