Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric triggerer_heartbeat #33320

Merged
merged 2 commits into from Aug 11, 2023

Conversation

vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Aug 11, 2023

Create and emit a new metric triggerer_heartbeat.

I manually verified that the metric is emitted and its value being incrementally increased.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@o-nikolas
Copy link
Contributor

Looks good, any screenshots or confirmation from manual testing that the metric is being emitted? Could add it to the description if so!

@vincbeck
Copy link
Contributor Author

Looks good, any screenshots or confirmation from manual testing that the metric is being emitted? Could add it to the description if so!

I did not take a screenshot but I tested the metric is emitted and its value getting incrementally increased. I used the option --integration otel in order to do so

@eladkal eladkal added this to the Airflow 2.8.0 milestone Aug 11, 2023
@eladkal eladkal added the type:improvement Changelog: Improvements label Aug 11, 2023
@hussein-awala hussein-awala merged commit 8c43fc5 into apache:main Aug 11, 2023
42 checks passed
@shubham22
Copy link

@hussein-awala - is it possible to include this in 2.7.x? It would be helpful for all customers adopting deferrables as Triggerer is a critical service, like Scheduler.

@potiuk
Copy link
Member

potiuk commented Aug 12, 2023

@hussein-awala - is it possible to include this in 2.7.x? It would be helpful for all customers adopting deferrables as Triggerer is a critical service, like Scheduler.

IMHO I think we can treat it as bugfix - missing metrics that should have been there already :D

@eladkal eladkal modified the milestones: Airflow 2.8.0, Airflow 2.7.1 Aug 12, 2023
@eladkal
Copy link
Contributor

eladkal commented Aug 12, 2023

I set it to 2.7.1 but final judgement call is for the release manager for that version

@vincbeck vincbeck deleted the vincbeck/triggerer_heartbeat branch August 14, 2023 14:02
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023
* Add metric `triggerer_heartbeat`

* Fix copy paste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues area:Triggerer kind:documentation type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants