New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric triggerer_heartbeat
#33320
Add metric triggerer_heartbeat
#33320
Conversation
docs/apache-airflow/administration-and-deployment/logging-monitoring/metrics.rst
Outdated
Show resolved
Hide resolved
Looks good, any screenshots or confirmation from manual testing that the metric is being emitted? Could add it to the description if so! |
I did not take a screenshot but I tested the metric is emitted and its value getting incrementally increased. I used the option |
@hussein-awala - is it possible to include this in 2.7.x? It would be helpful for all customers adopting deferrables as Triggerer is a critical service, like Scheduler. |
IMHO I think we can treat it as bugfix - missing metrics that should have been there already :D |
I set it to 2.7.1 but final judgement call is for the release manager for that version |
* Add metric `triggerer_heartbeat` * Fix copy paste
Create and emit a new metric
triggerer_heartbeat
.I manually verified that the metric is emitted and its value being incrementally increased.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.