Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow templating flower ingress hostnames #33363

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Allow templating flower ingress hostnames #33363

merged 1 commit into from
Aug 13, 2023

Conversation

kimminw00
Copy link
Contributor

@kimminw00 kimminw00 commented Aug 13, 2023 •
edited

I would like to propose allowing template values to flower ingress hostnames.

Why is it needed?
Let's assume that we're providing airflow service to multiple teams.
By creating flower ingress hostnames using {{ .Release.Namespace }} or {{ .Release.Name }},
there is no need to create multiple values ​​files to store different hostnames ​​for each team.

Usage

    hosts:
    #   # The hostname for the flower Ingress (can be templated)
    - name: '{{ .Release.Namespace }}.airflow.service.com'

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Aug 13, 2023
@potiuk potiuk merged commit 4d3d4a1 into apache:main Aug 13, 2023
48 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 13, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023
@kimminw00 @ferruzzi
Allow templating flower ingress hostnames (apache#33363)
d749605
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Assignees
No one assigned
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kimminw00 @potiuk @ephraimbuddy