-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure impersonation tests use a temporary AIRFLOW_HOME
#33422
Make sure impersonation tests use a temporary AIRFLOW_HOME
#33422
Conversation
3079fe6
to
6b4902b
Compare
Its great to see you again @Taragolis ! |
Well, sqlite test failure it is a bit expected, because impersonate user doesn't have access to |
Should not it be using the database in the temp AIRFLOW_HOME Then? We could simply add write access to that sqlite instanace and simply initialise and use it before every impersonation test as part of the "create_airflow_home" fixture. that sounds like best approach ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @Taragolis noted - the sqlite tests need a bit tweaking :)
Unfortunetly we initialise SQLite DB in The easiest solution in case of sqlite backend in breeze it would create DB in directory with 777 permissions and outside of AIRFLOW_HOME so everyone in breeze have access to this sqlite on read and write, I guess it is the same requirement for someone who want to use impersonation + sqlite |
Feel free to merge as-is if you are ok with it too and do not want to make any more changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, Looks Good +1
Continuation of #30313
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.