Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository_id and impersonation_chain to template fields in DataformCreateCompilationResultOperator #33585

Merged
merged 1 commit into from Aug 21, 2023

Conversation

bhagany
Copy link
Contributor

@bhagany bhagany commented Aug 21, 2023

All other operators template these fields, and impersonation_chain is explicity said to be templated in the operator's docstring

All other operators template these fields, and `impersonation_chain` is explicity said to be templated in the operator's docstring
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 21, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@hussein-awala hussein-awala changed the title Add missing template fields to DataformCreateCompilationResultOperator Add repository_id and impersonation_chain to template fields in DataformCreateCompilationResultOperator Aug 21, 2023
@potiuk potiuk merged commit 08fa814 into apache:main Aug 21, 2023
42 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 21, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants