Convert hard-coded allowlist error code to be argument of HttpSensor #33717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure. Good idea. But you need fix static checks (I recommend |
eladkal
reviewed
Aug 25, 2023
| @@ -62,6 +64,9 @@ def response_check(response, task_instance): | |||
| :param endpoint: The relative part of the full url | |||
| :param request_params: The parameters to be added to the GET url | |||
| :param headers: The HTTP headers to be added to the GET request | |||
| :param response_error_codes_whitelist: An whitelist to return False on poke(), not to raise exception. | |||
There was a problem hiding this comment.
please change variable name from response_error_codes_whitelist to response_error_codes_allowlist
There was a problem hiding this comment.
Thanks..! I'll be more careful in naming variable..! 🙇
Thank you for guiding me..! I reflected your feedbacks..! |
okayhooni
changed the title
|
You need to add allowlist to spelling.txt :) |
potiuk
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use
HttpSensorto roll out our Trino cluster(each with single coordinator) groups periodically with Airflow. In my use case, the503error has to be in the allowlist, same as404 Not Found.But, I noticed that
HttpSensorraiseAirflowExceptionwhen the target responds with503 Service Temporarily Unavailable.How about converting hard-coded
404to list-typed argumentresponse_error_codes_allowlist?There is already the alternative option with
extra_option={'check_response': False}, but the all or nothing method doesn't seem very fancy for covering all the use cases.