-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor unneeded 'continue' jumps around the repo #33849
Conversation
pass | ||
else: | ||
if v == default: | ||
del serialized_partial[k] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really any better/more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It keeps the v
variable in the successful try/else
line. But I'll revert it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types of PRs are always tricky to brain compile perfectly. But I don't spot any behaviour changes and the tests are passing. So LGTM 👍
3df3cdd
to
5a4b7a3
Compare
(cherry picked from commit 668aace)
No description provided.