-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the try outside the loop when this is possible in Airflow core #33975
Move the try outside the loop when this is possible in Airflow core #33975
Conversation
raise AirflowException(err) | ||
except ImportError as err: | ||
log.critical("Cannot import %s for API authentication due to: %s", backend, err) | ||
raise AirflowException(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at this, I wonder if we should remove this exception wrapping. It doesn’t have any value from what I can tell. Same for the one in __init__.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question because it seems useless. However I prefer to keep this PR changing the syntax without any change in the functionality, I will open some new PR to improve the raised exceptions.
All the blocks with this pattern
could be refactored to
Why?
To make the code more readable and fatser:
and here is the result:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.