-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unfound ab_user table in the CLI session #34120
Merged
Merged
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Sep 6, 2023
hussein-awala
force-pushed
the
fix/ab_user_cli
branch
from
September 6, 2023 07:41
4a1b7fd
to
80421e5
Compare
uranusjr
approved these changes
Sep 6, 2023
Lee-W
approved these changes
Sep 6, 2023
2 tasks
potiuk
approved these changes
Sep 6, 2023
2 tasks
2 tasks
@hussein-awala i see these warnings now:
appears related |
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 27, 2023
Introduced in apache#34120.
looks like this fixes it #34656 |
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 2f32769)
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34109
For some reason, the sqlalchemy sessions created in the CLI do not find the table
ab_user
, I tested different solutions such as providing the session to the methodtask_test
using provide_session decorator, using deferrable constraint and other solutions, and they did not work, but moving the foreign key to the column fixed the issue.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.