Use auth manager is_authorized_ APIs to check user permissions in Rest API
#34317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
jhtimmins,
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun,
ephraimbuddy and
potiuk
as code owners
boring-cyborg
bot
added
area:API
vincbeck
force-pushed
the
vincbeck/use_is_authorized
branch
from
43bf125
to
99a570f
Compare
vincbeck
changed the title
is_authorized_ to check user permissions in Rest API and other placesis_authorized_ APIs to check user permissions in Rest API and other places
vincbeck
changed the title
is_authorized_ APIs to check user permissions in Rest API and other placesis_authorized_ APIs to check user permissions in Rest API
vincbeck
force-pushed
the
vincbeck/use_is_authorized
branch
3 times, most recently
from
7fe1997
to
b595387
Compare
uranusjr
reviewed
Sep 13, 2023
vincbeck
force-pushed
the
vincbeck/use_is_authorized
branch
4 times, most recently
from
1e1b83d
to
b6b1619
Compare
vincbeck
added
the
use public runners
…est API and other places
vincbeck
force-pushed
the
vincbeck/use_is_authorized
branch
from
b6b1619
to
d843ac1
Compare
vincbeck
force-pushed
the
vincbeck/use_is_authorized
branch
from
fa0d91f
to
7ba129b
Compare
potiuk
reviewed
Oct 14, 2023
| DagAccessEntity.DEPENDENCIES: (RESOURCE_DAG_DEPENDENCIES,), | ||
| DagAccessEntity.IMPORT_ERRORS: (RESOURCE_IMPORT_ERROR,), | ||
| DagAccessEntity.RUN: (RESOURCE_DAG_RUN,), | ||
| DagAccessEntity.TASK: (RESOURCE_TASK_INSTANCE,), |
There was a problem hiding this comment.
Maybe we should leave a coomment here - that this is backwards compatibility due to originally wrong/misleading use of TASK_INSTANCE in FAB permissions?
There was a problem hiding this comment.
Sounds like a good idea :)
|
Re-reviewed, only few comments left. Also possibly #34942 should be merged first. |
potiuk
approved these changes
Oct 17, 2023
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 1, 2023
This decorator was added in apache#34317, but it seems it's not used anywhere. Opening this PR to see if I'm missing something
ephraimbuddy
added a commit
that referenced
this pull request
Nov 1, 2023
This decorator was added in #34317, but it seems it's not used anywhere. Opening this PR to see if I'm missing something
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
) This decorator was added in apache#34317, but it seems it's not used anywhere. Opening this PR to see if I'm missing something
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #32205.
In #33213,
is_authorized_APIs are introduced. This PR uses these new APIs across Airflow code. I mostly focused on the rest API but I also did it in some other places.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.