Refactor DataFusionInstanceLink usage #34514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Lee-W
approved these changes
Sep 23, 2023
eladkal
reviewed
Sep 28, 2023
moiseenkov
force-pushed
the
datafusion_refactor_project_id
branch
2 times, most recently
from
dffbc9a
to
cdd769f
Compare
|
@eladkal , @kaxil , @Taragolis , hi, |
moiseenkov
force-pushed
the
datafusion_refactor_project_id
branch
2 times, most recently
from
ffa8139
to
685c277
Compare
eladkal
reviewed
Oct 12, 2023
moiseenkov
force-pushed
the
datafusion_refactor_project_id
branch
from
685c277
to
8ceda52
Compare
eladkal
approved these changes
Oct 13, 2023
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored buggy
DataFusionPipelineLinkHelperinto a more generic function.