View util refactoring on mapped stuff use cases #34638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type hints added to task_group_to_grid and slightly tweaked the variables a bit to simplify things. The needs_expansion helper used elsewhere in the code base is reused to detect whether a thing "is mapped" or not instead ad-hoc checks.
uranusjr
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
bbovenzi
approved these changes
Sep 27, 2023
eladkal
added
the
type:misc/internal
eladkal
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type hints added to task_group_to_grid and slightly tweaked the variables a bit to simplify things. The
needs_expansionhelper used elsewhere in the code base is reused to detect whether a thing "is mapped" or not instead ad-hoc checks.Maybe some more refactorings coming if I can further figure out the overall logic of the function…