Fix metadata DB & port in Keda connection when usePgbouncer is false #34741
Conversation
hussein-awala
requested review from
dstandish and
jedcunningham
as code owners
|
@brokenjacobs this should fix the issue. Usually we don't create patch releases for the chart, but maybe we can wait a week and release a light patch release if other bugs are reported (to check with @jedcunningham) |
|
Yep, open to it. We've never really had the need before. |
|
Please see #34740 the database name is also incorrect. It uses the db name defined in the pgbouncer.ini, not the upstream database name. |
Thanks for your work on this! |
Indeed, I fixed it and I checked all the other values, all looks good! |
| @@ -48,7 +49,7 @@ data: | |||
| {{- end }} | |||
| {{- if and .Values.workers.keda.enabled .Values.pgbouncer.enabled (not .Values.workers.keda.usePgbouncer) }} | |||
| {{- with .Values.data.metadataConnection }} | |||
| kedaConnection: {{ urlJoin (dict "scheme" .protocol "userinfo" (printf "%s:%s" (.user | urlquery) (.pass | urlquery) ) "host" (printf "%s:%s" $metadataHost $metadataPort) "path" (printf "/%s" $database) "query" $query) | b64enc | quote }} | |||
| kedaConnection: {{ urlJoin (dict "scheme" .protocol "userinfo" (printf "%s:%s" (.user | urlquery) (.pass | urlquery) ) "host" (printf "%s:%s" $metadataHost $metadataPort) "path" (printf "/%s" $meadataDatabase) "query" $query) | b64enc | quote }} | |||
There was a problem hiding this comment.
typo nit meadataDatabase -> metadataDatabase
| @@ -27,7 +27,8 @@ | |||
| {{- $host := ternary $pgbouncerHost $metadataHost .Values.pgbouncer.enabled }} | |||
| {{- $metadataPort := .Values.data.metadataConnection.port | toString }} | |||
| {{- $port := ((ternary .Values.ports.pgbouncer $metadataPort .Values.pgbouncer.enabled) | toString) }} | |||
| {{- $database := (ternary (printf "%s-%s" .Release.Name "metadata") .Values.data.metadataConnection.db .Values.pgbouncer.enabled) }} | |||
| {{- $meadataDatabase := .Values.data.metadataConnection.db }} | |||
| {{- $database := (ternary (printf "%s-%s" .Release.Name "metadata") $meadataDatabase .Values.pgbouncer.enabled) }} | |||
There was a problem hiding this comment.
typo nit. $meadataDatabase -> metadataDatabase
hussein-awala
changed the title
ephraimbuddy
added
the
changelog:skip
closes: #34740
When
usePgbouncerand KEDA is activated, KEDA connection should use the metadata port instead of pgbouncer port.