fix: pgbouncer connection with useStandardNaming #34787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR apache#31066 introduced a new option to standardize the naming of the different helm chart resources. However this didn't include also updating the reference when creating the pgbouncer connection in the metadata secret. This PR fixes that and makes sure we use the proper hostname for pgbouncer based on the new option useStandardNaming
fgalind1
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
|
@jedcunningham I discovered a small issue with the recent addition of |
hussein-awala
approved these changes
Oct 5, 2023
fgalind1
changed the title
jedcunningham
approved these changes
Oct 5, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR #31066 introduced a new option to standardize the naming of the different helm chart resources.
However this didn't include also updating the reference when creating the pgbouncer connection in the
metadata secret. This PR fixes that and makes sure we use the proper hostname for pgbouncer based on
the new option
useStandardNamingHow to reproduce
Helm chart 1.11.0
Deploy airflow helm chart using
useStandardNaming: trueandpgbouncer.enabled: true, only when both are enabled the issue is presented, otherwise it works as it should