openlineage: adjust log levels #34801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDarDagran
force-pushed
the
openlineage/adjust-log-levels
branch
2 times, most recently
from
2e30896
to
0f9fe36
Compare
JDarDagran
force-pushed
the
openlineage/adjust-log-levels
branch
2 times, most recently
from
ff708c5
to
50cd52e
Compare
kaxil
reviewed
Oct 10, 2023
| @@ -82,7 +82,7 @@ def extract(self) -> OperatorLineage | None: | |||
| self.operator.__class__.__module__ + "." + self.operator.__class__.__name__ | |||
| ) | |||
| if fully_qualified_class_name in self.disabled_operators: | |||
| self.log.warning( | |||
| self.log.info( | |||
There was a problem hiding this comment.
This should be DEBUG too, no? i.e user performed an action to disable the lineage for specific operators
| @@ -144,10 +144,10 @@ def _get_openlineage_facets(self, get_facets_method, *args) -> OperatorLineage | | |||
| job_facets=facets.job_facets, | |||
| ) | |||
| except ImportError: | |||
| self.log.exception( | |||
| self.log.error( | |||
There was a problem hiding this comment.
Suggested change
| self.log.error( | |
| self.log.exception( |
exception seems fine here
| return | ||
| self.executor.submit(self.adapter.dag_success, dag_run=dag_run, msg=msg) | ||
|
|
||
| @hookimpl | ||
| def on_dag_run_failed(self, dag_run: DagRun, msg: str): | ||
| if not self.executor: | ||
| self.log.error("Executor have not started before `on_dag_run_failed`") | ||
| self.log.warning("Executor have not started before `on_dag_run_failed`") |
There was a problem hiding this comment.
Suggested change
| self.log.warning("Executor have not started before `on_dag_run_failed`") | |
| self.log.debug("Executor have not started before `on_dag_run_failed`") |
| @@ -194,14 +194,14 @@ def on_dag_run_running(self, dag_run: DagRun, msg: str): | |||
| @hookimpl | |||
| def on_dag_run_success(self, dag_run: DagRun, msg: str): | |||
| if not self.executor: | |||
| self.log.error("Executor have not started before `on_dag_run_success`") | |||
| self.log.warning("Executor have not started before `on_dag_run_success`") | |||
There was a problem hiding this comment.
Suggested change
| self.log.warning("Executor have not started before `on_dag_run_success`") | |
| self.log.debug("Executor have not started before `on_dag_run_success`") |
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/adjust-log-levels
branch
from
50cd52e
to
080e05d
Compare
|
Thanks @kaxil ! I've commited changes as suggested. |
kaxil
approved these changes
Oct 11, 2023
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenLineage provider is reported to be a bit too verbose. This PR attempts to lower logging levels of some messages and also cleans up the code.