Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redis broker URL with useStandardNaming #34825

Merged
merged 1 commit into from Oct 9, 2023

Conversation

seelmann
Copy link
Member

@seelmann seelmann commented Oct 8, 2023

PR #31066 introduced a new option to standardize the naming of the different helm chart resources. However this didn't include the hostname used in the redis connection URL.

How to reproduce

Helm chart 1.11.0

Deploy airflow helm chart using useStandardNaming: true, redis.enabled: true, and the default CeleryExecutor. Worker pods fail as they can't connect to redis.

@sseelmann
Copy link

sseelmann commented Oct 9, 2023

BTW, a possible workaround is to define a DNS cname:

# Workaround for https://github.com/apache/airflow/pull/34825, remove with next Helm Chart release
apiVersion: v1
kind: Service
metadata:
  name: my-release-redis
spec:
  type: ExternalName
  externalName: my-release-airflow-redis.my-namespace.svc.cluster.local

@jedcunningham jedcunningham merged commit 9a29738 into apache:main Oct 9, 2023
52 checks passed
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants