Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of cron-descriptor for custom TimeTables since BC in v1.3.0 #34836

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix usage of cron-descriptor for custom TimeTables since BC in v1.3.0 #34836

merged 1 commit into from
Oct 19, 2023

Commits on Oct 9, 2023

  1. Fix usage of cron-descriptor since BC in v1.3.0 

    When using a custom TimeTable that doesn't provide a CRON expression summary (e.g. : 'Custom TimeTable Plugin'),
and if the web UI has not yet load the TimeTable when deserializing the DAG,
accessing the grid view will try to parse the custom description as a CRON expression and then cron-descriptor, that introduce a breaking change in v1.3.0 that now calls 'parse' in the ctor of ExpressionDescriptor raise the FormatException outside of the try block

(working great in Airflow v2.4.2 that uses cron-descriptor v1.2.x)

C.f. : Salamek/cron-descriptor@ec9ea4d
    @poupounetjoyeux
    poupounetjoyeux committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    124114e View commit details
    Browse the repository at this point in the history