Helm chart should set AIRFLOW_HOME from airflowHome #34839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
jedcunningham and
hussein-awala
as code owners
chart/templates/_helpers.yaml
Outdated
Comment on lines
56
to
62
| {{- if .Values.enableBuiltInSecretEnvVars.AIRFLOW__CORE__FERNET_KEY }} | ||
| - name: AIRFLOW__CORE__FERNET_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ template "fernet_key_secret" . }} | ||
| key: fernet-key | ||
| {{- end }} |
There was a problem hiding this comment.
You didn't mean to remove this, right?
There was a problem hiding this comment.
corrrrect sir my b
| values={"airflowHome": exp_path}, | ||
| show_only=["templates/webserver/webserver-deployment.yaml"], | ||
| ) | ||
| assert {"name": "AIRFLOW_HOME", "value": exp_path} in jmespath.search( |
There was a problem hiding this comment.
Might be worth a test that the default is added as well?
hussein-awala
approved these changes
Oct 30, 2023
potiuk
approved these changes
Oct 31, 2023
dstandish
force-pushed
the
set-airflow-home-in-helm-chart
branch
from
372d650
to
7c70efe
Compare
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you change airflowHome from /opt/airflow to something else it doesn't totally work because the official image hardcodes the env var AIRFLOW_HOME. This should fix that.