Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add support for priorityClassName on Redis pods #34879

Merged
merged 3 commits into from Oct 28, 2023

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Oct 12, 2023

Fixes #34878

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 12, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@dntosas
Copy link
Contributor Author

dntosas commented Oct 12, 2023

hey team, also a qq: if this one is merged, do you have any ETA of the expected v1.12 release? TIA :)

@eladkal eladkal added this to the Airflow Helm Chart 1.12.0 milestone Oct 12, 2023
@amoghrajesh
Copy link
Contributor

cc @jedcunningham for the question regarding the next chart release dates

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes overall look good to me. However, can you add test cases in helm_tests/other/test_redis.py?

@dntosas
Copy link
Contributor Author

dntosas commented Oct 16, 2023

Changes overall look good to me. However, can you add test cases in helm_tests/other/test_redis.py?

sure mate, pushed those ^ thnx for pointing this out

@amoghrajesh
Copy link
Contributor

Triggered the CI. Changes look good

Signed-off-by: dntosas <ntosas@gmail.com>
@eladkal eladkal merged commit 14341ff into apache:main Oct 28, 2023
53 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 28, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 29, 2023
@dntosas dntosas deleted the feat/redis-priority-class branch January 19, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm] Redis does not include priorityClassName key
4 participants