New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add support for priorityClassName on Redis pods #34879
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hey team, also a qq: if this one is merged, do you have any ETA of the expected v1.12 release? TIA :) |
cc @jedcunningham for the question regarding the next chart release dates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes overall look good to me. However, can you add test cases in helm_tests/other/test_redis.py?
b17d8d1
to
48f3cb4
Compare
sure mate, pushed those ^ thnx for pointing this out |
Triggered the CI. Changes look good |
Signed-off-by: dntosas <ntosas@gmail.com>
48f3cb4
to
ce8142c
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Fixes #34878