New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to enable test connection #34905
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated from openapi/v1.yaml
and you should not modify it correctly. Modify the specification file instead and use pre-commit to sync the files instead. See the contribution guide located in the repository root to learn how to set up the dev toolchain.
Can you please also add the disclaimers from the release notes. Something alongside this:
|
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
description: | | ||
Test a connection. | ||
Testing Connections is disabled by default set test_connection flag to enabled in Airflow configuration (airflow.cfg). | ||
It can also be controlled by the environment variable AIRFLOW__CORE__TEST_CONNECTION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: | | |
Test a connection. | |
Testing Connections is disabled by default set test_connection flag to enabled in Airflow configuration (airflow.cfg). | |
It can also be controlled by the environment variable AIRFLOW__CORE__TEST_CONNECTION. | |
description: > | |
Test a connection. | |
Testing Connections is disabled by default set test_connection flag to enabled in Airflow configuration (airflow.cfg). | |
It can also be controlled by the environment variable `AIRFLOW__CORE__TEST_CONNECTION`. |
This fixes the rendering issues in the generated ts comment. (Don’t apply this on GitHub, you need to do this locally to go through pre-commit)
Did you forget to run the changes through pre-commit? |
I did run pre-commit, let me check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending CI
…irflow into docs-update-test-connection
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
--------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit ad15af5)
--------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit ad15af5)
with PR now testing connections is disabled by default, few docs were not updated with that information this PR is to update docs
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.