New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volumeClaimTemplate for worker in Helm chart #34986
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
@KHTee can you rebase and resolve conflicts? |
f324c1f
to
c7dc949
Compare
@eladkal rebase done |
Tests are failing :( |
c7dc949
to
af10e3f
Compare
The test added in this PR is failing
|
af10e3f
to
f1f6296
Compare
Yes, give me some time. I'm fixing the test cases. |
112f1b8
to
14986ed
Compare
@eladkal done fixing the test case |
14986ed
to
93da41c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to simplify the render method and fix the unit test. LGTM
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Problem: The current Helm chart doesn't support additional persistence volume for worker statefulset.
Resolution: Adding in new feature to add extra volumeClaimTemplates for additional persistent volume needed by statefulset.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.