Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volumeClaimTemplate for worker in Helm chart #34986

Merged
merged 2 commits into from Oct 30, 2023

Conversation

KHTee
Copy link
Contributor

@KHTee KHTee commented Oct 17, 2023

Problem: The current Helm chart doesn't support additional persistence volume for worker statefulset.

Resolution: Adding in new feature to add extra volumeClaimTemplates for additional persistent volume needed by statefulset.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 17, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal
Copy link
Contributor

eladkal commented Oct 27, 2023

@KHTee can you rebase and resolve conflicts?

@eladkal eladkal added this to the Airflow Helm Chart 1.12.0 milestone Oct 27, 2023
@KHTee KHTee force-pushed the volumeClaimTemplate branch 2 times, most recently from f324c1f to c7dc949 Compare October 28, 2023 04:34
@KHTee
Copy link
Contributor Author

KHTee commented Oct 28, 2023

@eladkal rebase done

@eladkal
Copy link
Contributor

eladkal commented Oct 28, 2023

@eladkal rebase done

Tests are failing :(

@eladkal
Copy link
Contributor

eladkal commented Oct 28, 2023

The test added in this PR is failing

=========================== short test summary info ============================
FAILED helm_tests/airflow_core/test_worker.py::TestWorker::test_should_add_extra_volume_claim_templates - subprocess.CalledProcessError: Command '['helm', 'template', 'release-name', '/opt/airflow/chart', '--values', '/tmp/tmp5japxht5', '--kube-version', '1.23.17', '--namespace', 'default', '--show-only', 'templates/workers/worker-deployment.yaml']' returned non-zero exit status 1.
================== 1 failed, 319 passed in 1753.87s (0:29:13) ==================

@KHTee
Copy link
Contributor Author

KHTee commented Oct 28, 2023

The test added in this PR is failing

=========================== short test summary info ============================
FAILED helm_tests/airflow_core/test_worker.py::TestWorker::test_should_add_extra_volume_claim_templates - subprocess.CalledProcessError: Command '['helm', 'template', 'release-name', '/opt/airflow/chart', '--values', '/tmp/tmp5japxht5', '--kube-version', '1.23.17', '--namespace', 'default', '--show-only', 'templates/workers/worker-deployment.yaml']' returned non-zero exit status 1.
================== 1 failed, 319 passed in 1753.87s (0:29:13) ==================

Yes, give me some time. I'm fixing the test cases.

@KHTee KHTee force-pushed the volumeClaimTemplate branch 3 times, most recently from 112f1b8 to 14986ed Compare October 28, 2023 10:23
@KHTee
Copy link
Contributor Author

KHTee commented Oct 28, 2023

@eladkal done fixing the test case

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to simplify the render method and fix the unit test. LGTM

@eladkal eladkal merged commit af99d5a into apache:main Oct 30, 2023
53 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 30, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants