Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: configurable mountPath for DAGs volume #35083

Merged
merged 3 commits into from Oct 25, 2023

Conversation

Aakcht
Copy link
Contributor

@Aakcht Aakcht commented Oct 20, 2023

This PR adds possibility to configure mountPath for DAGs volume. Configurable mountPath will make it possible to:

  • Add some rarely changing DAGs during image building to your dags_folder instead of receiving them from git.
  • mount to your DAGs folder custom configmaps (for example, to /dags_folder/my_custom_configmap).

closes: #34959


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@Aakcht
Copy link
Contributor Author

Aakcht commented Oct 25, 2023

@jedcunningham Please take a look, I updated the PR.

@jedcunningham jedcunningham merged commit ac53a9a into apache:main Oct 25, 2023
53 checks passed
@Aakcht Aakcht deleted the git_volume_mount_path branch October 25, 2023 17:45
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart: Allow mounting DAGs to a custom path in airflow containers.
5 participants