Fix weight_rule property type in mappedoperator #35257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Oct 30, 2023
eladkal
reviewed
Oct 30, 2023
| def weight_rule(self) -> int: # type: ignore[override] | ||
| def weight_rule(self) -> str: # type: ignore[override] |
There was a problem hiding this comment.
why do we need type: ignore here?
There was a problem hiding this comment.
We may not need it. Now, that we changed the return type from int to str, MappedOperator.weight_rule no longer deviates from it's parent AbstractOperator.weight_rule of type string.
There was a problem hiding this comment.
The weight_rule is defined in the superclass (AbstractOperator) as a normal attribute, but here, we override it to a property, so Mypy doesn't like this override. We have the same ignore for all the overridden attributes.
Lee-W
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.