Add try_number to extra links query #35317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchiapaikeo
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
vchiapaikeo
commented
Nov 1, 2023
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v1
branch
from
4c85bea
to
f422848
Compare
|
@jedcunningham , would you be able to give this a look? |
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v1
branch
from
f422848
to
cebd8dc
Compare
Add try_number to extra links query
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v1
branch
from
cebd8dc
to
0a18cfe
Compare
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v1
branch
from
0a18cfe
to
ec08b61
Compare
bbovenzi
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add try_number to extra links query
closes: #34623
Adds try_number to extra links query
Test Plan
console.log try_number in query -
Observe that link points to a specific table (test6) -
Make change to dag (tablename to test7) - reserialize dags - clear task and reinspect link without refreshing page:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.