Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Humanise log output about retrieved DAG(s) #35338

Merged
merged 1 commit into from Nov 2, 2023
Merged

Humanise log output about retrieved DAG(s) #35338

merged 1 commit into from Nov 2, 2023

Conversation

Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Nov 1, 2023 •
edited

Simple replace dict_keys(['dag1', 'dag2']) output to a bit more humanise representation 'dag1', 'dag2'

WAS

[2023-11-01T12:24:14.820+0000] {logging_mixin.py:154} INFO - [2023-11-01T12:24:14.819+0000] {dagbag.py:538} INFO - Filling up the DagBag from /files/dags/pr_35338_multiple.py
[2023-11-01T12:24:14.857+0000] {processor.py:833} INFO - DAG(s) dict_keys(['issue_35338_dag_5', 'issue_35338_dag_1', 'issue_35338_dag_3', 'issue_35338_dag_2', 'issue_35338_dag_4']) retrieved from /files/dags/pr_35338_multiple.py
[2023-11-01T12:24:14.820+0000] {logging_mixin.py:154} INFO - [2023-11-01T12:24:14.819+0000] {dagbag.py:538} INFO - Filling up the DagBag from /files/dags/pr_35338_multiple.py
[2023-11-01T12:24:14.857+0000] {processor.py:833} INFO - DAG(s) dict_keys(['issue_35338_dag_5', 'issue_35338_dag_1', 'issue_35338_dag_3', 'issue_35338_dag_2', 'issue_35338_dag_4']) retrieved from /files/dags/pr_35338_multiple.py

IS

[2023-11-01T12:26:29.814+0000] {logging_mixin.py:154} INFO - [2023-11-01T12:26:29.813+0000] {dagbag.py:538} INFO - Filling up the DagBag from /files/dags/pr_35338_single.py
[2023-11-01T12:26:29.843+0000] {processor.py:833} INFO - DAG(s) 'issue_35338_dag_0' retrieved from /files/dags/pr_35338_single.py
[2023-11-01T12:26:29.820+0000] {logging_mixin.py:154} INFO - [2023-11-01T12:26:29.820+0000] {dagbag.py:538} INFO - Filling up the DagBag from /files/dags/pr_35338_multiple.py
[2023-11-01T12:26:29.844+0000] {processor.py:833} INFO - DAG(s) 'issue_35338_dag_4', 'issue_35338_dag_5', 'issue_35338_dag_3', 'issue_35338_dag_1', 'issue_35338_dag_2' retrieved from /files/dags/pr_35338_multiple.py

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Nov 1, 2023
@Taragolis Taragolis added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 1, 2023
@Taragolis Taragolis marked this pull request as ready for review November 1, 2023 12:32
@Taragolis Taragolis added this to the Airflow 2.7.4 milestone Nov 1, 2023
hussein-awala
hussein-awala approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@potiuk potiuk merged commit 99a77a7 into apache:main Nov 2, 2023
45 checks passed
@Taragolis Taragolis deleted the dag-processor-humanize branch November 2, 2023 21:17
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
@Taragolis @romsharon98
Humanise log output about retrieved DAG(s) (apache#35338)
ff3a489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees
No one assigned
Labels
area:Scheduler Scheduler or dag parsing Issues type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
Airflow 2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Taragolis @potiuk @hussein-awala @ephraimbuddy