Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional exit code to list import errors #35378

Merged

Conversation

drapail
Copy link
Contributor

@drapail drapail commented Nov 2, 2023


Added a flag to list-import-errors command that returns exit code '1' if there are import errors. Will be useful when used in CI pipelines.

Copy link

boring-cyborg bot commented Nov 2, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to return it always and remove the flag. There is no particular agreement about the exit codes of CLI commands, and I think it's fair to assume that exit code should be non-zero when there are erros by default.

@potiuk
Copy link
Member

potiuk commented Nov 2, 2023

(especially that it fails the tests)

@drapail drapail force-pushed the add-optional-exit-code-to-list-import-errors branch from 620afbb to 4969d31 Compare November 3, 2023 08:49
@drapail
Copy link
Contributor Author

drapail commented Nov 3, 2023

I suggest to return it always and remove the flag. There is no particular agreement about the exit codes of CLI commands, and I think it's fair to assume that exit code should be non-zero when there are erros by default.

Agree, fixed it

@potiuk potiuk merged commit 660cf06 into apache:main Nov 3, 2023
45 checks passed
Copy link

boring-cyborg bot commented Nov 3, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
* added --strict flag to return non-zero exit code fro list-import-errors cli command

* removed unnecessary comment

* remove flag and make 1 default exit code

---------

Co-authored-by: Maksym Dibrov - Personal <personal@ip-10-20-20-111.eu-central-1.compute.internal>
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants