New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional exit code to list import errors #35378
Add optional exit code to list import errors #35378
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to return it always and remove the flag. There is no particular agreement about the exit codes of CLI commands, and I think it's fair to assume that exit code should be non-zero when there are erros by default.
(especially that it fails the tests) |
620afbb
to
4969d31
Compare
Agree, fixed it |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* added --strict flag to return non-zero exit code fro list-import-errors cli command * removed unnecessary comment * remove flag and make 1 default exit code --------- Co-authored-by: Maksym Dibrov - Personal <personal@ip-10-20-20-111.eu-central-1.compute.internal>
Added a flag to list-import-errors command that returns exit code '1' if there are import errors. Will be useful when used in CI pipelines.