Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long custom operator name overflows in graph view #35382

Merged
merged 2 commits into from Nov 17, 2023
Merged

Long custom operator name overflows in graph view #35382

merged 2 commits into from Nov 17, 2023

Conversation

ivan-afonichkin
Copy link
Contributor

Fixes overflow issue with long custom operator names in the DAG view.

Before:
Screenshot 2023-11-02 at 20 49 35

After:
Screenshot 2023-11-02 at 20 49 52

closes: #33693

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Nov 2, 2023
@eladkal eladkal added this to the Airflow 2.7.4 milestone Nov 2, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Nov 2, 2023
@ivan-afonichkin
Copy link
Contributor Author

@potiuk or @bbovenzi could you please take a look? Thanks!

Taragolis
Taragolis approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with TypeScript, so I can't review code itself, but result looks good to me.

@ivan-afonichkin
Copy link
Contributor Author

@potiuk or @bbovenzi just a ping here, please take a look whenever you have time, thanks!

@ivan-afonichkin
Copy link
Contributor Author

@ryanahamilton @ashb @bbovenzi @pierrejeambrun hey :), you seem to be the owners? Could you please take a look?

@ivan-afonichkin
Copy link
Contributor Author

@Taragolis do you know if I need to get anyone else approval or someone can merge it?

@bbovenzi bbovenzi merged commit 4d872b8 into apache:main Nov 17, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taragolis Taragolis Taragolis approved these changes

@bbovenzi bbovenzi bbovenzi approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.8.0
Development

Successfully merging this pull request may close these issues.

Long custom operator name overflows in graph view
5 participants
@ivan-afonichkin @Taragolis @bbovenzi @ephraimbuddy @eladkal