Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric values in DAG details are incorrectly rendered as timestamps #35538

Merged
merged 4 commits into from Nov 14, 2023
Merged

Numeric values in DAG details are incorrectly rendered as timestamps #35538

merged 4 commits into from Nov 14, 2023

Conversation

ivan-afonichkin
Copy link
Contributor

Resolves issue of rendering certain numbers in some browsers as dates as opposed to numbers. This issue is well described: on this page.

Before:
Screenshot 2023-11-08 at 19 19 30

After:
Screenshot 2023-11-08 at 19 18 53

closes: #35500

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Nov 8, 2023
@ivan-afonichkin
Copy link
Contributor Author

@Taragolis could you take a look please? Thanks!

hussein-awala
hussein-awala approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Taragolis
Taragolis approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result looks good!

potiuk
potiuk approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... That certainly reminds me the mother of all ligthing talk presentations.

If you've never seen it, this is going to be the best spend 5 minutes of your time. Ever.

https://www.destroyallsoftware.com/talks/wat

@potiuk
Copy link
Member

potiuk commented Nov 9, 2023

If you have seen it already, watch it again. this will be the second-best-spent 5 minutes. Ever.

@bbovenzi bbovenzi added this to the Airflow 2.7.4 milestone Nov 14, 2023
@bbovenzi bbovenzi merged commit 76ceeb4 into apache:main Nov 14, 2023
46 checks passed
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Nov 20, 2023
@Taragolis Taragolis mentioned this pull request Dec 15, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@Taragolis Taragolis Taragolis approved these changes

@bbovenzi bbovenzi bbovenzi approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.8.0
Development

Successfully merging this pull request may close these issues.

Numeric values in DAG details are incorrectly rendered as timestamps
6 participants
@ivan-afonichkin @potiuk @Taragolis @bbovenzi @hussein-awala @ephraimbuddy