draft: Add templates for PVC storageClassName #35544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
|
You need to (heavily) rebase. ABR (Always Be Rebased):
|
It was not possible to do path / int which is a typical thing when using date partioned files.
This PR marks DB tests as such and allows to split execution of the tests in CI to run the DB tests with the various database while the non-db tests - without the DB in a separate run. In order to do that, the code to select which tests to run has been moved from `entrypoint_ci.sh` bash to breeze's Python code, which is generally much nicer to maintain and common for both "DB" and "non-DB" tests. This will have the nice side effect that it will be easier in the future to manage different test types and contain some specific flaky test types. This change also adds possibility to isolate some of the test types when parallel DB tests are run and adds new test type PythonOperator carved out Operator type. This test is best run in isolation becasue creating and destroing virtualenvs in Docker while running in parallel to other tests is very slow for some reason and leads to flaky tests. Python operator tests are therefore separated out from Operators and treated separately as isolated tests. This will help not only with speed but also with stability of the test suite.
* Improve docs on objectstorage Add more explanations, limitations and add example of attaching a filesystem.
This PR switches the formatter we use from Black to Ruff, now that Ruff's introduced a [formatter](https://docs.astral.sh/ruff/formatter/). The Ruff formatter is ~30x as fast as Black, and we already use Ruff for linting. This PR also upgrades the version of Ruff to the latest. Note that this doesn't swap the formatter used in inline Python code in the docs as I haven't seen an easy way of getting the Ruff formatter working with it. Because of this, a lot of the Black code hasn't been removed (i.e. the code to upgrade black, etc).
…ch (apache#35313) We need to do it in order to be able to generate PyPI constraints, because common.io has apache-airflow>=2.8.0 requirement that conflicts with the current 2.8.0dev0
The Pytest-icdiff plugin produces much more readable, coloured diffs from failed assertions.
* Add use_krb5ccach option to sparkSubmitOperator
* Use slightly nicer job name for Non-DB tests in CI To be consistend with DB tests - we show both Python version and set of test types we use for the job. * Update .github/workflows/ci.yml Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
romsharon98
requested review from
o-nikolas,
Fokko,
josh-fell,
mik-laj,
uranusjr,
jhtimmins,
ryanahamilton,
bbovenzi,
ephraimbuddy,
bolkedebruin and
XD-DENG
as code owners
* chore(helm): safer worker pod annotations * chore(helm): safer worker pod annotations --------- Co-authored-by: hakuno <me@seiji.com.br> Co-authored-by: Hussein Awala <hussein@awala.fr>
romsharon98
changed the title
romsharon98
force-pushed
the
feature/templating-storage-class-name
branch
9 times, most recently
from
c9d347c
to
e50bc01
Compare
|
I opened a new branch for this PR: #35581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix this issue #32581
Fixes: #32581